Skip to content

Revert "Remove AbstractNode from RenderObject and deprecate it" - #129125

Closed
CaseyHillers wants to merge 1 commit into
masterfrom
revert-128973-removeAbstractFromRender
Closed

CaseyHillers wants to merge 1 commit into
masterfrom
revert-128973-removeAbstractFromRender

Conversation

@CaseyHillers

Copy link
Copy Markdown
Contributor

Reverts #128973

This has broken a large number of goldens and tests for Google.

See b/287958958

@CaseyHillers
CaseyHillers requested a review from goderbauer June 19, 2023 14:37
@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Jun 19, 2023

@zanderso zanderso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@CaseyHillers

Copy link
Copy Markdown
Contributor Author

Further bisection resulted in it being b/286999102

@guidezpl
guidezpl deleted the revert-128973-removeAbstractFromRender branch April 18, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants