Skip to content

Use devicectl to check for iOS 17 device connection - #129287

Closed
vashworth wants to merge 3 commits into
flutter:masterfrom
vashworth:devicectl
Closed

vashworth wants to merge 3 commits into
flutter:masterfrom
vashworth:devicectl

Conversation

@vashworth

Copy link
Copy Markdown
Contributor

xcdevice (the Xcode CLI tool we use to get iOS physical device information) does not show the correct connection interface ('usb' vs 'network') for iOS 17 devices. Xcode 15 introduced a device connectivity stack called CoreDevice and new tool called devicectl to interact with it. This PR adopts usage of devicectl to get connection information for iOS 17 devices.

Note: devicectl is currently in preview and may change in the future. As a result, this PR is very defensive about errors and only prints them using printTrace, to minimize visibility to users.

Fixes #128827.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 21, 2023
@vashworth vashworth closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter cannot identify iOS 17 devices as wireless

1 participant