Repository navigation
Enable 'flutter test' on Windows. - #13459
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
bkonyi
added
platform-windows
| final String engineArtifactsPath = cache.getArtifactDirectory('engine').path; | ||
| final String platformDirName = getNameForTargetPlatform(platform); | ||
| String path = fs.path.join(engineArtifactsPath, platformDirName, _artifactToFileName(artifact)); | ||
| return (platform == TargetPlatform.windows_x64) ? (path + '.exe') : path; |
There was a problem hiding this comment.
Are you sure this needs the .exe? For gen_snapshot for example we just provide the file name without ending and I believe the process lib figures out which ending is actually required...
| } else if (getCurrentHostPlatform() == HostPlatform.darwin_x64) { | ||
| return fs.path.join(engineOutPath, 'flutter_tester'); | ||
| } else if (getCurrentHostPlatform() == HostPlatform.windows_x64) { | ||
| return fs.path.join(engineOutPath, 'flutter_tester.exe'); |
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
This is sooo cool!
Before you submit this you should probably make sure that the flutter_tester for Windows gets uploaded to the cloud and roll the engine to a revision where it is available to make sure that the command doesn't fail due to missing binary.
3 participants
No description provided.