Skip to content

Remove long-skipped test - #136295

Closed
Hixie wants to merge 1 commit into
masterfrom
Hixie-patch-4
Closed

Hixie wants to merge 1 commit into
masterfrom
Hixie-patch-4

Conversation

@Hixie

@Hixie Hixie commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

"Fixes" #53707

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is le sad, also curious, what is the reason for removing? Is it a bad test or a flake we cannot fix?

@flutter-dashboard

Copy link
Copy Markdown

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie

Hixie commented Nov 28, 2023

Copy link
Copy Markdown
Contributor Author

The reason for deleting it is that it's just taking up cognitive space and clearly nobody is concerned enough about the test to debug it and make it pass. That said, this isn't enough to delete the test actually, so I'm going to close this and try again.

@Hixie Hixie closed this Nov 28, 2023
@Hixie
Hixie deleted the Hixie-patch-4 branch November 28, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants