Skip to content

AnimationStyle.noAnimation replaces AnimatedTheme with just Theme in MaterialApp.themeAnimationStyle - #138619

Closed
TahaTesser wants to merge 1 commit into
flutter:masterfrom
TahaTesser:update_MaterialApp
Closed

AnimationStyle.noAnimation replaces AnimatedTheme with just Theme in MaterialApp.themeAnimationStyle#138619
TahaTesser wants to merge 1 commit into
flutter:masterfrom
TahaTesser:update_MaterialApp

Conversation

@TahaTesser

@TahaTesser TahaTesser commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

fixes AnimationStyle.noAnimation needs to replace AnimatedTheme with just Theme in the MaterialApp

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Nov 17, 2023
@TahaTesser
TahaTesser marked this pull request as ready for review November 17, 2023 14:46
@HansMuller HansMuller mentioned this pull request Nov 17, 2023
Merged
8 tasks done
@TahaTesser TahaTesser closed this Nov 18, 2023
@TahaTesser
TahaTesser deleted the update_MaterialApp branch November 18, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AnimationStyle.noAnimation needs to replace AnimatedTheme with just Theme in the MaterialApp

1 participant

@TahaTesser