Skip to content

[CP-beta]Revise tooltip theme docs, including more cross-references - #142152

Closed
flutteractionsbot wants to merge 1 commit into
flutter:flutter-3.19-candidate.1from
flutteractionsbot:cp-beta-e661ed3a00312a25820178bba9eac70006a2d3c7
Closed

flutteractionsbot wants to merge 1 commit into
flutter:flutter-3.19-candidate.1from
flutteractionsbot:cp-beta-e661ed3a00312a25820178bba9eac70006a2d3c7

Conversation

@flutteractionsbot

Copy link
Copy Markdown
Contributor

This pull request is opened against a release branch.

To request a cherry pick of a commit, please fill in the form below.
(Questions with an asterisk are required.)

To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords.

A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.

  • Issue Link: What is the link to the issue this cherry-pick is addressing?
  My Answer:


  My Answer:


  • Impacted Users: Approximately who will hit this issue (ex. all Flutter devs, Windows developers, all end-customers, apps using X framework feature)?
  My Answer:


  • impact_description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
  My Answer:


  • Workaround: Is there a workaround for this issue?
  My Answer:


  • Risk: What is the risk level of this cherry-pick?
  My Answer:
  - [ ] Low
  - [ ] Medium
  - [ ] High

  • Test Coverage: Are you confident that your fix is well-tested by automated tests?
  My Answer:
  - [ ] Yes
  - [ ] No

  • Validation Steps: What are the steps to validate that this fix works?
  My Answer:


…37316)

Much of the new wording here is borrowed from [ChipTheme], [SliderTheme], or [RadioThemeData], which I think are pretty good. I believe a lot of other theme classes have similar wording too. I've also made some tweaks of my own, notably the references to [MaterialApp.theme].

This started from a desire to have clearer cross-references pointing at what to do with a FooThemeData to make it take effect:
  flutter#135879 (comment)
but then as I started writing I kept finding more and more small things I wanted to adjust, including a couple of bits that were extraneous or obsolete.
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Jan 24, 2024
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jan 24, 2024
@XilaiZhang

Copy link
Copy Markdown
Contributor

this looks expected. used for testing purposes. closing now.

@XilaiZhang XilaiZhang closed this Jan 24, 2024
@flutteractionsbot
flutteractionsbot deleted the cp-beta-e661ed3a00312a25820178bba9eac70006a2d3c7 branch July 20, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cp: review Cherry-picks in the review queue framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants