Skip to content

[CP-beta][flutter_tools] remove await runZonedGuarded() in tests - #142349

Closed
flutteractionsbot wants to merge 1 commit into
flutter:flutter-3.19-candidate.1from
flutteractionsbot:cp-beta-97fef98b47ab9d66b2428ec40ec7f6fb04906a79
Closed

flutteractionsbot wants to merge 1 commit into
flutter:flutter-3.19-candidate.1from
flutteractionsbot:cp-beta-97fef98b47ab9d66b2428ec40ec7f6fb04906a79

Conversation

@flutteractionsbot

Copy link
Copy Markdown
Contributor

This pull request is opened against a release branch.

To request a cherry pick of a commit, please fill in the form below.
(Questions with an asterisk are required.)

To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords.

A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.

  • Issue Link: What is the link to the issue this cherry-pick is addressing?
  My Answer:


  My Answer:


  • Impacted Users: Approximately who will hit this issue (ex. all Flutter devs, Windows developers, all end-customers, apps using X framework feature)?
  My Answer:


  • impact_description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
  My Answer:


  • Workaround: Is there a workaround for this issue?
  My Answer:


  • Risk: What is the risk level of this cherry-pick?
  My Answer:
  - [ ] Low
  - [ ] Medium
  - [ ] High

  • Test Coverage: Are you confident that your fix is well-tested by automated tests?
  My Answer:
  - [ ] Yes
  - [ ] No

  • Validation Steps: What are the steps to validate that this fix works?
  My Answer:


@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Jan 26, 2024
@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 26, 2024
@XilaiZhang

Copy link
Copy Markdown
Contributor

looks good, testing, closing

@XilaiZhang XilaiZhang closed this Jan 26, 2024
@flutteractionsbot
flutteractionsbot deleted the cp-beta-97fef98b47ab9d66b2428ec40ec7f6fb04906a79 branch July 20, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cp: review Cherry-picks in the review queue tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants