Skip to content

[CP-beta]Remove duplicate global declaration of UserMessages - #142350

Closed
flutteractionsbot wants to merge 1 commit into
flutter:flutter-3.19-candidate.1from
flutteractionsbot:cp-beta-69c98bd960e9d135bbd363536ecb58b2ad952df4
Closed

flutteractionsbot wants to merge 1 commit into
flutter:flutter-3.19-candidate.1from
flutteractionsbot:cp-beta-69c98bd960e9d135bbd363536ecb58b2ad952df4

Conversation

@flutteractionsbot

Copy link
Copy Markdown
Contributor

This pull request is opened against a release branch.

To request a cherry pick of a commit, please fill in the form below.
(Questions with an asterisk are required.)

To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords.

A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.

  • Issue Link: What is the link to the issue this cherry-pick is addressing?
  My Answer:


  My Answer:


  • Impacted Users: Approximately who will hit this issue (ex. all Flutter devs, Windows developers, all end-customers, apps using X framework feature)?
  My Answer:


  • impact_description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
  My Answer:


  • Workaround: Is there a workaround for this issue?
  My Answer:


  • Risk: What is the risk level of this cherry-pick?
  My Answer:
  - [ ] Low
  - [ ] Medium
  - [ ] High

  • Test Coverage: Are you confident that your fix is well-tested by automated tests?
  My Answer:
  - [ ] Yes
  - [ ] No

  • Validation Steps: What are the steps to validate that this fix works?
  My Answer:


Fixes flutter#142286

This is a refactor. No code behavior changes should be observed.
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Jan 26, 2024
@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Jan 26, 2024
@XilaiZhang

Copy link
Copy Markdown
Contributor

Looks good, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems cp: review Cherry-picks in the review queue tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants