You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix the second TextFormField to trigger onTapOutside - #148112
Unfortunately, I think your change is not going to solve the problem without making more problems.
If you look at the failing tests, there are a number of cases where your change breaks existing scenarios.
One of the main reasons that TapRegion exists is so that we can bind widgets together into groups that don't trigger loss of focus. For instance, if you want to add formatting (bold, italic, etc.) buttons to a text field, but don't want clicking on those buttons to unfocus the text field, then you wrap them in a TextFieldTapRegion, which uses the same tap groupId as all of the text fields do, which is just the EditableTextType object itself.
Hope is not lost, though: To fix the problem you have, you'll need to figure out a way to give each text field a separate tap region groupId object that doesn't break the existing use cases. Perhaps a parameter on TextField that lets you supply the groupId object to EditableText, which overrides the default of EditableText?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a: text inputEntering text in a text field or keyboard related problemsframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #127597
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.