Skip to content

Removed brand references from MenuAnchor.dart - #148432

Closed
davidhicks980 wants to merge 6 commits into
flutter:mainfrom
davidhicks980:patch-1
Closed

davidhicks980 wants to merge 6 commits into
flutter:mainfrom
davidhicks980:patch-1

Conversation

@davidhicks980

Copy link
Copy Markdown
Contributor

Rephrases identifier from _isApple to _isCupertino.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels May 15, 2024
@goderbauer
goderbauer requested a review from victorsanni May 17, 2024 21:07
@victorsanni victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label May 17, 2024
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 17, 2024
@auto-submit

auto-submit Bot commented May 17, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/148432, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@victorsanni victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label May 17, 2024
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 17, 2024
@auto-submit

auto-submit Bot commented May 17, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/148432, Failed to merge flutter/flutter/148432 with Pull request flutter/flutter/148432 could not be merged: You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information..

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit

auto-submit Bot commented May 20, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/148432, Failed to merge flutter/flutter/148432 with Pull request flutter/flutter/148432 could not be merged: You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information..

@gspencergoog

gspencergoog commented May 20, 2024 •

Copy link
Copy Markdown
Contributor

Hi @davidhicks980 Thanks for the PR. There's only one problem: this is a PR against the main branch, not against master. We're still in the process of migrating to main and it doesn't yet allow us to commit on main, only master. Could you please create a new PR against master and tag me and @victorsanni on it so we can get it committed?

@davidhicks980

Copy link
Copy Markdown
Contributor Author

See #148760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants