Repository navigation
[CP-stable]Update FocusManager platform check to include iOS - #148976
Closed
flutteractionsbot wants to merge 1 commit into
Closed
flutteractionsbot wants to merge 1 commit into
flutteractionsbot wants to merge 1 commit into
Conversation
Both iOS and Android run into issues when the FocusManager starts responding to app lifecycle changes. Fortunately, this feature is primarily meant for desktop platforms, so the problem can be resolved with a platform check. fixes flutter#148475
Contributor
Author
|
@jmagman please fill out the PR description above, afterwards the release team will review this request. |
github-actions
Bot
added
framework
| ChangeNotifier.maybeDispatchObjectCreation(this); | ||
| } | ||
| if (kIsWeb || defaultTargetPlatform != TargetPlatform.android) { | ||
| final bool shouldListenToAppLifecycle = switch (defaultTargetPlatform) { |
Contributor
There was a problem hiding this comment.
@nate-thegrate Sorry but it looks like I missed it in the original review: why's this ignoring kIsWeb now?
Contributor
There was a problem hiding this comment.
Looks like the test is failing too.
Contributor
There was a problem hiding this comment.
Good catch, thank you!
Member
|
Given the revert, closing. Based on my "What is the risk level of this cherry-pick? --> Low" answer being totally off, I think this might be better to let this bake in master a bit instead of hotfixing. |
flutteractionsbot
deleted the
cp-stable-8d955cdd644edd089d5545e83615d68b01d62c1c
branch
July 20, 2026 17:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link:
#148475
Changelog Description:
On iOS, selecting an email/password autofill suggestion should populate the input fields.
Impact Description:
In iOS apps, selecting an autofill suggestion does not populate the input fields.
Workaround:
No
Risk:
What is the risk level of this cherry-pick?
This essentially reverses #142930 on non-desktop platforms.
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Though this flow could really use platform-specific integration tests (cc @nate-thegrate)
Validation Steps:
Code sample and instructions at #148475 (comment)