Repository navigation
Remove flaky flag from all tests that are green for the whole dashboard - #15443
Merged
Merged
Conversation
Plus run_machine_concurrent_hot_reload which isn't all green, but is green since the fix was pushed.
yjbanov
approved these changes
Mar 12, 2018
Contributor
|
I'm as optimistic as you are, @DanTup 😄 So LGTM.
|
Contributor
Author
|
Travis reported failures only with the "allowed failures" steps, and since I don't think this change actually changes anything that runs on Travis anyway, I've merged. I'll check the dashboard after it's had time to build a few. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed at #14636 (comment), this marks those that are all green for the visible history as not-flaky and also
run_machine_concurrent_hot_reloadwhich isn't all green, but is green since the fix was pushed.This leaves only one test marked as flaky which is
hot_mode_dev_cycle_ios__preview_dart_2_benchmarkwhich has one yellow square on the dashboard.I don't know if any of the others are still flaky, so there's a danger that this will result in failures if they are "really infrequently flaky" so let me know if you think we should revert any of these.