Repository navigation
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
framework
nate-thegrate
left a comment
nate-thegrate
left a comment
There was a problem hiding this comment.
Hi @yeasin50, thanks for contributing!
This PR will need a test to make sure we don't accidentally undo the fix in the future (as per the bot comment), and the existing tests need to pass as well.
Feel free to reply here if you have questions!
|
This looks like a duplicate of #153162, but we have not heard back from them. Just FYI as this progresses. |
|
Another PR has been opened for this, #155214. If we have not heard back on this, we may go ahead with landing that PR if it resolves the issue. |
3 participants
Fixes #154701 CarouselView children are not clickable
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.