Skip to content

Optimize InkWell widget states resolution - #159546

Closed
bleroux wants to merge 1 commit into
flutter:masterfrom
NevercodeHQ:optimize_ink_well_widget_states_resolution
Closed

bleroux wants to merge 1 commit into
flutter:masterfrom
NevercodeHQ:optimize_ink_well_widget_states_resolution

Conversation

@bleroux

@bleroux bleroux commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

Description

This PR moves the Set operations logic introduced in #159072 outside of build method. Not sure it will help but this is the only computations added in #159072.

Related Issue

Related to #159337.

Tests

No semantic change. This PR will need a test exemption.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Nov 27, 2024
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@bleroux

bleroux commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

Closing because it turned out the perf regression was not related to the initial change.
See #159337 (comment)

@bleroux bleroux closed this Jan 8, 2025
@bleroux
bleroux deleted the optimize_ink_well_widget_states_resolution branch February 24, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant