Skip to content

remove formatter from snippet tool #161347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Jan 9, 2025
Merged

remove formatter from snippet tool #161347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions dev/snippets/bin/snippets.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import 'package:process/process.dart';
import 'package:snippets/snippets.dart';

const String _kElementOption = 'element';
const String _kFormatOutputOption = 'format-output';
const String _kHelpOption = 'help';
const String _kInputOption = 'input';
const String _kLibraryOption = 'library';
Expand Down Expand Up @@ -165,11 +164,6 @@ void main(List<String> argList) {
defaultsTo: environment['INVOCATION_INDEX'],
help: 'A unique serial number for this snippet tool invocation.',
);
parser.addFlag(
_kFormatOutputOption,
defaultsTo: true,
help: 'Applies the Dart formatter to the published/extracted sample code.',
);
parser.addFlag(
_kHelpOption,
negatable: false,
Expand Down Expand Up @@ -201,7 +195,6 @@ void main(List<String> argList) {
return;
}

final bool formatOutput = args[_kFormatOutputOption]! as bool;
final String packageName = args[_kPackageOption] as String? ?? '';
final String libraryName = args[_kLibraryOption] as String? ?? '';
final String elementName = args[_kElementOption] as String? ?? '';
Expand Down Expand Up @@ -268,7 +261,7 @@ void main(List<String> argList) {

for (final CodeSample sample in element.samples) {
sample.metadata.addAll(metadata);
snippetGenerator.generateCode(sample, output: output, formatOutput: formatOutput);
snippetGenerator.generateCode(sample, output: output);
print(snippetGenerator.generateHtml(sample));
}

Expand Down
1 change: 0 additions & 1 deletion dev/snippets/lib/snippets.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
export 'src/analysis.dart';
export 'src/configuration.dart';
export 'src/data_types.dart';
export 'src/import_sorter.dart';
export 'src/snippet_generator.dart';
export 'src/snippet_parser.dart';
export 'src/util.dart';
Loading