Skip to content

fix FadeForwardsTransitionBuilder input irresponsive during return animation #164241 - #168277

Closed
TheLastFlame wants to merge 7 commits into
flutter:masterfrom
TheLastFlame:fix_fade_forwards_blocking_interaction
Closed

fix FadeForwardsTransitionBuilder input irresponsive during return animation #164241#168277
TheLastFlame wants to merge 7 commits into
flutter:masterfrom
TheLastFlame:fix_fade_forwards_blocking_interaction

Conversation

@TheLastFlame

@TheLastFlame TheLastFlame commented May 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Depends on: #167032

Fix: #164241

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages f: routes Navigator, Router, and related APIs. labels May 3, 2025
@TheLastFlame

TheLastFlame commented May 3, 2025

Copy link
Copy Markdown
Contributor Author

Only the last 2 commits apply to this pr 😅

@TheLastFlame
TheLastFlame force-pushed the fix_fade_forwards_blocking_interaction branch from 2247738 to 94a7889 Compare May 6, 2025 06:52
@dkwingsmt
dkwingsmt requested a review from justinmc May 7, 2025 18:43
@justinmc justinmc mentioned this pull request May 16, 2025
Merged
9 tasks done
justinmc
justinmc reviewed May 16, 2025
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fixed now as of #168425?

Sorry if there was overlap there and I didn't notice this PR. If so it looks like we solved the problem in different ways, I wonder if this one has any advantage?

@TheLastFlame

TheLastFlame commented May 17, 2025

Copy link
Copy Markdown
Contributor Author

@justinmc, yes, your pr fixes this problem. I don't think there is any fundamental difference. You can close this pr and the issue that is associated with it.

@dkwingsmt

dkwingsmt commented May 21, 2025

Copy link
Copy Markdown
Contributor

I'm closing this PR then. Feel free to open other ones if there are remaining problems. :)

@dkwingsmt dkwingsmt closed this May 21, 2025
@dkwingsmt dkwingsmt mentioned this pull request May 21, 2025
Closed
@justinmc

justinmc commented May 29, 2025

Copy link
Copy Markdown
Contributor

Thanks @TheLastFlame and sorry again for stepping on your toes here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc left review comments

Assignees

No one assigned

Labels

f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FadeForwardsTransitionBuilder input irresponsive during return animation

4 participants

@TheLastFlame @dkwingsmt @justinmc @rkishan516