Repository navigation
Snackbar timeout - #173127
Closed
victorsanni wants to merge 5 commits into
Closed
Snackbar timeout#173127victorsanni wants to merge 5 commits into
victorsanni wants to merge 5 commits into
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request changes the behavior of SnackBar timeouts. Now, a SnackBar with an action will not time out, regardless of accessibility settings. This is a good improvement for user experience. The implementation correctly moves the timeout logic to ScaffoldMessengerState and updates documentation and tests accordingly.
However, I've found a potential accessibility regression where snackbar animations are no longer disabled when accessibility features are enabled. I've left a comment with details on how to address this.
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.