Skip to content

Make image resolution more strict, clean gallery pubspec.yaml (#17241) - #17322

Merged
HansMuller merged 2 commits into
flutter:masterfrom
fmatosqg:image_asset_scale_detection
May 26, 2018
Merged

HansMuller merged 2 commits into
flutter:masterfrom
fmatosqg:image_asset_scale_detection

Conversation

@fmatosqg

@fmatosqg fmatosqg commented May 5, 2018

Copy link
Copy Markdown
Contributor

Addresses #17241

@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@fmatosqg

fmatosqg commented May 5, 2018

Copy link
Copy Markdown
Contributor Author

I have no idea who the other "contributor" for this patch is. It sounds like my local git is picking a stale alternative github account I may have used in the past.

@fmatosqg
fmatosqg force-pushed the image_asset_scale_detection branch from 932c6f6 to 1982c20 Compare May 5, 2018 08:22
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels May 5, 2018
@fmatosqg

Copy link
Copy Markdown
Contributor Author

@HansMuller This appveyor error is very interesting, I have no idea what to do next. My guess is that running it again may work:

FileSystemException: Deletion failed, path = 'C:\Users\appveyor\AppData\Local\Temp\1\analyze_sample_code_86ff9924-5516-11e8-81e7-00155d57f4bf' (OS Error: The process cannot access the file because it is being used by another process.

@HansMuller

Copy link
Copy Markdown
Contributor

Sorry, that looks like a build flake. I've restarted the AppVeyor bot

@fmatosqg

Copy link
Copy Markdown
Contributor Author

@HansMuller all green on CI 👍

@HansMuller
HansMuller merged commit 7d25378 into flutter:master May 26, 2018
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants