Skip to content

Mark testWidgets() and testUsingContext() with @isTest. - #17772

Merged
scheglov merged 1 commit into
flutter:masterfrom
scheglov:mark-isTest
May 21, 2018
Merged

scheglov merged 1 commit into
flutter:masterfrom
scheglov:mark-isTest

Conversation

@scheglov

@scheglov scheglov commented May 21, 2018 •

Copy link
Copy Markdown
Contributor

flutter/flutter-intellij#2055

So, invocations of these functions are displayed in IDE Structure view.

image

@gspencergoog

Copy link
Copy Markdown
Contributor

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@yjbanov

yjbanov commented May 21, 2018 •

Copy link
Copy Markdown
Contributor

What does the structure view show when I do the following?

for (int i = 0; i < 10; i++) {
  testWidgets('test $i', (_) async {});
}

@scheglov

Copy link
Copy Markdown
Contributor Author

The goal of the Structure view is to simplify navigation.
We just represent AST in a useful way.
So, we show just single invocation.

image

@yjbanov

yjbanov commented May 21, 2018

Copy link
Copy Markdown
Contributor

That sounds reasonable. LGTM.

@scheglov
scheglov merged commit eba194f into flutter:master May 21, 2018
@scheglov
scheglov deleted the mark-isTest branch May 21, 2018 18:11
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants