Repository navigation
Send an event at startup with the protocol version and pid - #17873
Conversation
|
code lgtm It looks like there are test failures based on the unit tests not expecting the new, initial event. Re: updating the protocol docs, doing that after that lands sgtm. We could also (after this PR) move the docs to a markdown file in the repo, and update the wiki to point to that doc. That would allos us to do atomic changes of the protocol and its docs. |
I'll take a look. I wasn't sure how to reliably run all of the tests so I figured my friend Travis would help :)
Yeah, that sounds good to me. I'll take a look once this PR is good to go. |
|
There are still some weird failures on Travis, like this: Doesn't seem like something I could've caused, but I'll do some digging next week before landing this. |
|
Re-reading the logs, I think the devfs failures are as a result of a timeout:
I think the subsequent tests failed because the test that timed out didn't clean up properly. The tests seem to pass locally for me. I've rebased on master which is forcing the tests to run again, so if they all pass this time I'll land this. |
The pid will help with some of the issues of terminate the process when launched through a shell script and the version will allow clients to make decisions about supported features. I've also bumped the protocol version number for two reasons: 1. This change 2. We didn't increase it when we added the previous emulator commands
The pid will help with some of the issues of terminate the process when launched through a shell script and the version will allow clients to make decisions about supported features.
I've also bumped the protocol version number for two reasons:
This event appears both when running
flutter daemonandflutter run --machine.@devoncarew I called it
daemon.connectedbecause the analysis server already used the nameconnectedfor a similar event and it seemed consistent, but shout if you want me to change it.(I'll update the wiki page once this is agreed/approved too - I presume those changes are instant and can't go in a PR?).