Add keyboard support for RangeSlider by xxxOVALxxx · Pull Request #181525 · flutter/flutter

xxxOVALxxx · 2026-01-27T03:57:02Z

This PR adds keyboard support for RangeSlider and new tests. I took this implementation from Slider

This PR fixes the following issue: #179638

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request adds keyboard support to the RangeSlider widget, a feature that was previously missing. The changes include handling keyboard inputs to adjust the slider's start and end thumbs, with support for both LTR and RTL text directions. New tests have been added to verify this functionality. My review focuses on improving code structure and readability. I've suggested a refactoring to reduce code duplication in the widget's build method.

hannah-hyj

LGTM

chunhtai · 2026-01-30T23:02:19Z

+    final Map<ShortcutActivator, Intent> shortcutMap = switch (MediaQuery.navigationModeOf(
+      context,
+    )) {
+      NavigationMode.directional => _directionalNavShortcutMap,


reading at the doc and the original issue #54877, the arrow key should be completely ignored in this mode.

Am I correct in understanding that when using the D-pad, Thumbs control should be ignored? What should happen then when using directional mode?

I'm not very familiar with d-pad controls on TVs. Maybe we need this behavior? But how do we change the value then?

Screen.Recording.2026-01-31.at.19.45.16.mov

I suggest that in direction mode, the entire RangeSlider should be the focusable element, and to change values, you need to press Enter to switch to “Edit” mode.

from my experience, if using d pad, a user will need to first hit confirm which will lock them in the control to adjust the value by d pad. It sounds like a non trivial work though. Consider leave a todo here and fix that in a separate pr

Added the TODO. Thanks for the feedback!

can you also file an issue and link it here?

can you link the issue in the todo as well?

xxxOVALxxx · 2026-02-05T19:54:06Z

I've created issue #181968 to track the NavigationMode.directional behavior that @chunhtai mentioned. This issue will only manifest after this PR is merged

chunhtai

LGTM, just one minor comment

chunhtai · 2026-02-20T23:51:18Z

+    final Map<ShortcutActivator, Intent> shortcutMap = switch (MediaQuery.navigationModeOf(
+      context,
+    )) {
+      NavigationMode.directional => _directionalNavShortcutMap,


can you link the issue in the todo as well?

hannah-hyj

LGTM

chunhtai

LGTM

auto-submit · 2026-04-07T02:26:28Z

autosubmit label was removed for flutter/flutter/181525, because - The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Mac_x64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

dkwingsmt · 2026-04-08T18:32:53Z

Thanks for your contribution! This PR has reached completion, however we're not able to merge this PR for the moment due to the Material/Cupertino code freeze (#184093). As soon as the decoupling is complete, we will post a way to port this PR to the new packages to land. In the meantime, I'll convert this PR to a draft and apply a label so that we can quickly find it when the freeze is lifted.

dkwingsmt · 2026-04-08T18:33:51Z

Also I've rebased this PR because the check failure appear to be the result of the recent CICD hiccups.

dkwingsmt

Approving to trigger Google tests

meredithslota · 2026-05-29T18:46:23Z

Hello! Just checking on the timeline here — this is the likely root cause of a GAR bug on our side (b/496500215) and the earlier code freeze is now thawed. Can this be reviewed/submitted?

Piinks · 2026-06-24T21:20:59Z

I've marked this PR as not ready to port to flutter/packages yet.
We'll provide instructions to move this change over to material_ui/cupertino_ui once ready to receive PRs. Thank you!

dkwingsmt · 2026-08-28T17:40:31Z

This PR is ready to port to flutter/packages! 🥳
See guidance and instructions in #188444

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jan 27, 2026

gemini-code-assist Bot reviewed Jan 27, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/material/range_slider.dart

xxxOVALxxx force-pushed the keyboard_support_for_range_slider branch from 3d086e6 to 7f79f06 Compare January 27, 2026 14:01

hannah-hyj self-requested a review January 28, 2026 00:09

hannah-hyj added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jan 28, 2026

hannah-hyj previously approved these changes Jan 30, 2026

View reviewed changes

hannah-hyj requested a review from chunhtai January 30, 2026 21:26

chunhtai reviewed Jan 30, 2026

View reviewed changes

github-actions Bot removed the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Feb 5, 2026

xxxOVALxxx mentioned this pull request Feb 5, 2026

RangeSlider needs alternative input method for NavigationMode.directional #181968

Closed

hannah-hyj added this pull request to the merge queue Feb 9, 2026

hannah-hyj removed this pull request from the merge queue due to a manual request Feb 9, 2026

hannah-hyj requested a review from chunhtai February 9, 2026 22:33

chunhtai reviewed Feb 20, 2026

View reviewed changes

xxxOVALxxx dismissed hannah-hyj’s stale review via 5d11614 March 12, 2026 22:21

dkwingsmt added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 25, 2026

dkwingsmt requested review from chunhtai and hannah-hyj March 25, 2026 18:16

hannah-hyj approved these changes Mar 25, 2026

View reviewed changes

chunhtai approved these changes Apr 6, 2026

View reviewed changes

chunhtai added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Apr 6, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2026

xxxOVALxxx added 5 commits April 8, 2026 11:33

Add keyboard support for RangeSlider

51023b1

Remove unnecessary Shortcuts

97f4daf

Add TODO

258dd56

Add link to issue

b417168

Update

bf81252

dkwingsmt force-pushed the keyboard_support_for_range_slider branch from ce2b9f8 to bf81252 Compare April 8, 2026 18:33

github-actions Bot removed the CICD Run CI/CD label Apr 8, 2026

dkwingsmt added the CICD Run CI/CD label Apr 8, 2026

dkwingsmt approved these changes Apr 8, 2026

View reviewed changes

dkwingsmt added the waiting for code freeze This PR is waiting for a code freeze to resolve. label Apr 8, 2026

dkwingsmt marked this pull request as draft April 15, 2026 18:13

mbcorona mentioned this pull request Jun 10, 2026

Add alternative input method for RangeSlider in NavigationMode.directional #187816

Closed

10 tasks done

Piinks added the Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. label Jun 24, 2026

mbcorona mentioned this pull request Aug 26, 2026

[material_ui] Add alternative input method for RangeSlider in NavigationMode.directional flutter/packages#12630

Merged

11 tasks done

dkwingsmt added Decoupling: Port to flutter/packages This PR is ready to be ported to flutter/packages. We will provide instructions to do so. and removed Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. labels Aug 28, 2026

xxxOVALxxx mentioned this pull request Aug 29, 2026

[material_ui] Add keyboard support for RangeSlider flutter/packages#12687

Closed

Conversation

xxxOVALxxx commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

xxxOVALxxx Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

xxxOVALxxx Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

xxxOVALxxx Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

chunhtai Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

xxxOVALxxx commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Apr 7, 2026

Uh oh!

dkwingsmt commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkwingsmt commented Apr 8, 2026

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

meredithslota commented May 29, 2026

Uh oh!

Piinks commented Jun 24, 2026

Uh oh!

dkwingsmt commented Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xxxOVALxxx commented Jan 27, 2026 •

edited

Loading

xxxOVALxxx Jan 31, 2026 •

edited

Loading

xxxOVALxxx commented Feb 5, 2026 •

edited

Loading

dkwingsmt commented Apr 8, 2026 •

edited

Loading