Repository navigation
Conversation
|
Note that there are a very large number of diffs for shadow_path_geometry.cc - the algorithm was not changed (one minor tweak in one place where I fat-fingered a condition from the original Skia source), it's all name changes to acknowledge that it is no longer only used for shadows. I probably shouldn't have bothered until I had the prototype up and running, but it felt odd requesting data for a "shadow" that wasn't a shadow. If this prototype lands, the entire PolygonInfo class should be moved and renamed to something less shadow-specific. (Indeed these classes are in the Skia code as "Poly utils" and only refer to insets and outsets.) |
|
Greetings from stale PR triage! 👋 |
@walley892 is currently working on SDF paths, I'll donate this PR to their effort... |
|
Welcome back to stale triage! How is this going? :) |
|
One of many solutions being pursued for #185117, this PR can be reopened if the others don't pan out. |
Prototypes a solution for #183960
Work in Impeller is ongoing to develop SDF shaders for various primitives such as Circle, RoundRect, etc. These specific solutions will not work for arbitrary paths. This PR is a prototype for using the existing ShaderGeometry code to produce geometry meshes hinted with SDF parameters to render antialiased versions of convex paths.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.