Skip to content

Adds impeller gl context clear guard - #187332

Closed
gaaclarke wants to merge 4 commits into
flutter:masterfrom
gaaclarke:context-clear-guard
Closed

gaaclarke wants to merge 4 commits into
flutter:masterfrom
gaaclarke:context-clear-guard

Conversation

@gaaclarke

Copy link
Copy Markdown
Member

issue: #166248

Speculative fix for #166248.

This ports over one of the safety guards from Skia over to Impeller:

if (eglGetCurrentContext() != context_) {

This makes sure that if the context is not the current context when attempting to clear, it is a noop.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 29, 2026
@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 29, 2026
@gaaclarke gaaclarke changed the title Context clear guard Adds impeller gl context clear guard May 29, 2026
@gaaclarke

Copy link
Copy Markdown
Member Author

This didn't work under testing, it was a good idea though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant