Repository navigation
Refactor SwiftPM symlink path logic - #188647
Merged
auto-submit[bot] merged 4 commits intoAug 14, 2026
Merged
Conversation
github-actions
Bot
added
platform-ios
vashworth
marked this pull request as ready for review
June 26, 2026 21:47
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Swift Package Manager integration in flutter_tools to determine which plugins require symlinking by their name rather than their basename, particularly when the basename does not match the plugin name or when there are inter-plugin dependencies. It also updates the plugin copying process to exclude the example directory and appends the original basename as a comment in the manifest. The review feedback suggests appending a trailing slash to the source path in the rsync command to prevent nested directories, updating the corresponding test expectations, and explicitly handling the nullable return value of pluginSwiftPackageManifestPath for improved type safety.
9 of 10 tasks
stuartmorgan-g
approved these changes
Aug 12, 2026
vashworth
added
the
autosubmit
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 12, 2026
flutter-dashboard
Bot
removed
the
autosubmit
cbracken
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xcode caches Swift package manifests and only re-processes them when the path or the contents of the manifest change. To ensure that the package manifest is re-processed when the Flutter plugin version changes, we use the basename as the symlink plugin directory name since the basename has the version number in it.
However, the basename cannot be used in the following scenarios:
This PR copies plugins where the basename can't be used into the build directory and inserts a comment into the Package.swift to force Xcode to re-process it.
Fixes #186881. Fixes #188147. Fixes #188646
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.