Repository navigation
Remove dead code checking < Xcode 15 - #189103
Conversation
github-actions
Bot
added
tool
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes explicit Xcode version checks across various commands, migrations, and project checks, replacing them with simpler checks for whether Xcode is installed. The review feedback highlights a compilation issue in build_swift_package.dart where Dart's flow analysis cannot promote the nullable field _xcode to a non-nullable type, and suggests assigning it to a local variable first.
|
I think this should also be updated |
| ]); | ||
| } | ||
| return _isDevicectlInstalled ?? false; | ||
| return _isDevicectlInstalled ??= _processUtils.exitsHappySync(<String>[ |
There was a problem hiding this comment.
the currentVersion is needed in cases where the xcode isnt installed. If not, the command triggers a blocking UI dialog prompting the user to install the Command Line Tools, which could cause the tooling to hang
There was a problem hiding this comment.
Good to know, thanks for the catch.
cbracken
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
jmagman
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
3 participants
As of #180531 the Xcode minimum is Xcode 15. Remove dead code that checked < 15.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.