Repository navigation
[flutter_tools] Fix PathNotFoundException during native assets cleanup - #190102
Merged
auto-submit[bot] merged 5 commits intoAug 5, 2026
Merged
Conversation
Avoid crashing with a PathNotFoundException if a file is deleted by the OS or another process after being listed but before being deleted by the tool. Use ErrorHandlingFileSystem.deleteIfExists instead of entity.delete.
github-actions
Bot
added
the
tool
bkonyi
marked this pull request as ready for review
August 4, 2026 16:34
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the native assets installation process to use ErrorHandlingFileSystem.deleteIfExists when cleaning up stale files in the target directory, and adds a regression test for this behavior. The review feedback suggests eagerly collecting the directory contents into a list before iterating and deleting to prevent potential FileSystemException issues on Windows.
dcharkes
approved these changes
Aug 5, 2026
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Aug 5, 2026
bkonyi
added
the
cp: stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid crashing with a PathNotFoundException if a file is deleted by the OS or another process after being listed but before being deleted by the tool.
Use ErrorHandlingFileSystem.deleteIfExists instead of entity.delete.
Fixes #190234