Repository navigation
[flutter_tools] Handle WDAC block error code 4551 for impellerc - #190108
Merged
auto-submit[bot] merged 4 commits intoAug 5, 2026
Merged
Conversation
On Windows, when impellerc is blocked by Windows Defender Application Control (WDAC), it throws a ProcessException with error code 4551. Define the constant for this error code next to the existing code 1260 and check for it in ShaderCompiler._isBlockedBySecurityPolicy to exit gracefully.
This was referenced Aug 4, 2026
bkonyi
force-pushed
the
fix-impellerc-wdac-block-4551-final
branch
from
August 4, 2026 15:57
be31ac7 to
88d83ba
Compare
bkonyi
marked this pull request as ready for review
August 4, 2026 17:21
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ShaderCompiler to handle Windows error code 4551 (winErrorSystemIntegrityPolicyViolation), which occurs when the Impeller shader compiler is blocked by Windows Defender Application Control (WDAC). A regression test has been added to verify that this error triggers a ToolExit and logs an appropriate message. There are no review comments, so I have no additional feedback to provide.
gaaclarke
approved these changes
Aug 4, 2026
Contributor
|
autosubmit label was removed for flutter/flutter/190108, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This was referenced Aug 5, 2026
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[flutter_tools] Handle WDAC block error code 4551 for impellerc
On Windows, when impellerc is blocked by Windows Defender Application Control (WDAC),
it throws a ProcessException with error code 4551.
Define the constant for this error code next to the existing code 1260 and check for it
in ShaderCompiler._isBlockedBySecurityPolicy to exit gracefully.
Fixes #190232