Skip to content

[flutter_tools] Handle WDAC block error code 4551 for impellerc - #190108

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
bkonyi:fix-impellerc-wdac-block-4551-final
Aug 5, 2026
Merged

auto-submit[bot] merged 4 commits into
flutter:masterfrom
bkonyi:fix-impellerc-wdac-block-4551-final

Conversation

@bkonyi

@bkonyi bkonyi commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

[flutter_tools] Handle WDAC block error code 4551 for impellerc

On Windows, when impellerc is blocked by Windows Defender Application Control (WDAC),
it throws a ProcessException with error code 4551.
Define the constant for this error code next to the existing code 1260 and check for it
in ShaderCompiler._isBlockedBySecurityPolicy to exit gracefully.

Fixes #190232

On Windows, when impellerc is blocked by Windows Defender Application Control (WDAC),
it throws a ProcessException with error code 4551.
Define the constant for this error code next to the existing code 1260 and check for it
in ShaderCompiler._isBlockedBySecurityPolicy to exit gracefully.
@bkonyi
bkonyi force-pushed the fix-impellerc-wdac-block-4551-final branch from be31ac7 to 88d83ba Compare August 4, 2026 15:57
@bkonyi
bkonyi marked this pull request as ready for review August 4, 2026 17:21
@bkonyi
bkonyi requested a review from gaaclarke August 4, 2026 17:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ShaderCompiler to handle Windows error code 4551 (winErrorSystemIntegrityPolicyViolation), which occurs when the Impeller shader compiler is blocked by Windows Defender Application Control (WDAC). A regression test has been added to verify that this error triggers a ToolExit and logs an appropriate message. There are no review comments, so I have no additional feedback to provide.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2026
@auto-submit

auto-submit Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/190108, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_tools] Handle WDAC block error code 4551 for impellerc

2 participants