Repository navigation
[flutter_tools] Fix impellerc Windows Unicode crash and improve diagnostics - #190112
Merged
auto-submit[bot] merged 7 commits intoAug 5, 2026
Merged
Conversation
- Fix C++ path conversion in impellerc switches.cc to use Utf8FromPath. - Capture and include stdout/stderr in ShaderCompilerException. - Add platform-specific hints for Gatekeeper and Unicode paths.
github-actions
Bot
added
tool
…der compiler regression test
bkonyi
force-pushed
the
fix-shader-compiler-exception
branch
from
August 4, 2026 15:58
45aaa92 to
7c561d3
Compare
bkonyi
marked this pull request as ready for review
August 5, 2026 14:23
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the error reporting and diagnostics of the shader compiler (impellerc) by capturing stdout and stderr on failure, adding platform-specific troubleshooting hints (such as macOS Gatekeeper/OOM and Windows non-ASCII path warnings), and updating C++ path handling to use UTF-8. The review feedback suggests using a malformed-tolerant UTF-8 codec to prevent decoding crashes on localized system messages, and trimming the captured stdout and stderr outputs to avoid trailing newlines in the exception message.
gaaclarke
previously approved these changes
Aug 5, 2026
Member
|
This sounds like something we'd want to cherry-pick? |
Contributor
Author
Probably a good idea! |
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Aug 6, 2026
This was referenced Aug 7, 2026
bkonyi
added
the
cp: stable
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix impellerc crash on Windows when paths contain Unicode characters, and improve diagnostics by capturing stdout/stderr and adding helpful hints.
Fixes #190233