Repository navigation
Migrate platform_view example to material_ui - #190309
auto-submit[bot] merged 1 commit into
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the first-party package:flutter/material.dart import with the third-party package:material_ui/material_ui.dart in the platform_view example, adds material_ui as a dependency, and removes the example from the cross-import check list. Feedback recommends reverting these changes to ensure Flutter examples exclusively use first-party SDK packages and remain covered by the cross-import checks.
| sdk: flutter | ||
| material_ui: ^0.0.2 |
There was a problem hiding this comment.
Do not add the external material_ui package as a dependency. Core Flutter examples must rely on the built-in Flutter SDK libraries.
sdk: flutter
|
Looks like the failure is unrelated to your change. I'd rebase and try again |
a63a941 to
025af63
Compare
57ae36a to
18b4a74
Compare
QuncCccccc
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/190309, because - The status or check suite Mac_arm64_verify_binaries has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
18b4a74 to
655a3dd
Compare
QuncCccccc
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
3 participants
Migrates the platform_view example to import material_ui.
Related to #190093.
Pre-launch Checklist
///).