Repository navigation
Migrate example image_list to material_ui - #190363
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the core SDK import package:flutter/material.dart with an external package material_ui in the flutter_view and image_list examples, adding it as a dependency in their pubspec.yaml files. The review feedback notes that replacing the official Flutter SDK libraries with an external package introduces supply chain risks and architectural regressions, and recommends reverting to the built-in SDK.
| import 'package:flutter/material.dart'; | ||
|
|
||
| import 'package:flutter/services.dart'; | ||
| import 'package:material_ui/material_ui.dart'; |
There was a problem hiding this comment.
Replacing the core SDK package package:flutter/material.dart with an external package material_ui is a security risk and an architectural regression. Flutter examples must use the official Flutter SDK libraries.
| import 'package:material_ui/material_ui.dart'; | |
| import 'package:flutter/material.dart'; |
| sdk: flutter | ||
|
|
||
|
|
||
| material_ui: ^0.0.2 |
There was a problem hiding this comment.
Do not add material_ui as a dependency. Flutter examples should rely on the built-in flutter SDK for Material Design components.
| import 'package:flutter/material.dart'; | ||
|
|
||
| import 'package:flutter/services.dart'; | ||
| import 'package:material_ui/material_ui.dart'; |
There was a problem hiding this comment.
Replacing the core SDK package package:flutter/material.dart with an external package material_ui is a security risk and an architectural regression. Flutter examples must use the official Flutter SDK libraries.
| import 'package:material_ui/material_ui.dart'; | |
| import 'package:flutter/material.dart'; |
| # Use with the CupertinoIcons class for iOS style icons. | ||
|
|
||
|
|
||
| material_ui: ^0.0.2 |
There was a problem hiding this comment.
Do not add material_ui as a dependency. Flutter examples should rely on the built-in flutter SDK for Material Design components.
06f40c9 to
513e014
Compare
justinmc
changed the title
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
Should we remove 'examples/image_list/lib/main.dart', in dev/bots/check_examples_cross_imports.dart
|
Ah I forgot, thank you @QuncCccccc! |
|
The Google failure seems unrelated? I'm pushing a rebase. |
e6298d0 to
2ef31a0
Compare
justinmc
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
justinmc
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
3 participants
Migrates the image_list example to material_ui.
Part of #190093.