Refactor `flutter_view` example to not use `material` by Renzo-Olivares · Pull Request #190377 · flutter/flutter

Renzo-Olivares · 2026-07-31T23:38:55Z

This PR refactors the flutter_view example to not use material.

It also migrates the iOS app to utilize the UIScene lifecycle. Without the migration the app refused to run, and showed the error below.

failure in void _UIApplicationEvaluateRuntimeIssueForNoSceneLifecycleAdoption(void)_block_invoke (UIApplication_RuntimeIssues.m:106) : Application
  failed to launch: UIScene life cycle is required for apps built with this SDK. See "Transitioning to the UIKit scene-based life cycle" in the UIKit
  documentation for more information on migration.

Android:

Screen.Recording.2026-07-31.at.6.13.12.PM.mov

iOS:

Screen.Recording.iPhone.17.Pro.07-31-2026.at.5.40.35.PM.mp4

Part of #190305

Pre-launch Checklist

gemini-code-assist

Code Review

This pull request migrates the flutter_view example from using Material Design (MaterialApp, Scaffold, FloatingActionButton) to a lightweight implementation using WidgetsApp and custom widgets. It also adds iOS SceneDelegate support for the UISceneSession lifecycle. Feedback suggests defining a default textStyle in WidgetsApp to eliminate redundant styling on individual Text widgets, and updating the custom _FloatingActionButton constructor to support super.key.

flutter-dashboard · 2026-08-01T01:20:00Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

navaronbracke · 2026-08-04T06:33:56Z

This will also need to be removed from the examples checker, though

justinmc

LGTM, but as @navaronbracke said I thought you would have to remove this file from the cross import checker. I don't know how CI is passing. Maybe this PR was created before that checker was added?

flutter/dev/bots/check_examples_cross_imports.dart

Line 571 in 88b4103

'examples/flutter_view/lib/main.dart',

justinmc · 2026-08-04T19:27:05Z

+  }
+}
+
+class Button extends StatelessWidget {


Nit: Maybe make it private so it's clear to readers that it's not part of Flutter.

navaronbracke · 2026-08-04T19:40:36Z

LGTM, but as @navaronbracke said I thought you would have to remove this file from the cross import checker. I don't know how CI is passing. Maybe this PR was created before that checker was added?

flutter/dev/bots/check_examples_cross_imports.dart

Line 571 in 88b4103

'examples/flutter_view/lib/main.dart',

I've wondered that before. Is it running in CI?

Renzo-Olivares · 2026-08-05T17:49:12Z

@justinmc pointed out this PR was on a flutter base that did not contain check_examples_cross_imports.dart so maybe that's why the test was not failing. I've rebased and removed flutter_view from the list.

Renzo-Olivares · 2026-08-05T17:51:14Z

              relativePath.startsWith('examples/api/test/widgets') =>
        _ApiExampleLibrary(relativePath),
      _
-          when relativePath.startsWith('examples/flutter_view') ||


Is it necessary to delete flutter_view from here as well?

No, this is part of the checker itself. I'd just remove it from the exclusion list and leave the rest as is.

+1, leaving this means the checker will continue to check this directory, which it should do in case we ever accidentally add a cross import back in there.

justinmc

Re LGTM 👍

justinmc · 2026-08-05T23:29:56Z

+}
+
+class _Button extends StatelessWidget {
+  const _Button({super.key, required this.onPressed, required this.icon});


Looks like this is failing CI because key is never used.

justinmc

LGTM 👍

justinmc

LGTM but heads up there appear to be unrelated failures.

github-actions Bot added the d: examples Sample code and demos label Jul 31, 2026

Renzo-Olivares marked this pull request as ready for review August 1, 2026 01:14

gemini-code-assist Bot reviewed Aug 1, 2026

View reviewed changes

Comment thread examples/flutter_view/lib/main.dart

Comment thread examples/flutter_view/lib/main.dart

Comment thread examples/flutter_view/lib/main.dart Outdated

Comment thread examples/flutter_view/lib/main.dart

Comment thread examples/flutter_view/lib/main.dart Outdated

Renzo-Olivares added the CICD Run CI/CD label Aug 3, 2026

Renzo-Olivares requested a review from justinmc August 3, 2026 18:12

Piinks added the framework flutter/packages/flutter repository. See also f: labels. label Aug 3, 2026

Renzo-Olivares mentioned this pull request Aug 3, 2026

[Decoupling] Migrate examples to material_ui and cupertino_ui #190093

Closed

navaronbracke previously approved these changes Aug 4, 2026

View reviewed changes

justinmc previously approved these changes Aug 4, 2026

View reviewed changes

Renzo-Olivares dismissed stale reviews from justinmc and navaronbracke via b667481 August 5, 2026 17:43

github-actions Bot removed the framework flutter/packages/flutter repository. See also f: labels. label Aug 5, 2026

Renzo-Olivares force-pushed the flutter_view_revamp branch from b667481 to 94cd9c7 Compare August 5, 2026 17:44

Renzo-Olivares requested review from justinmc and navaronbracke August 5, 2026 17:46

Renzo-Olivares commented Aug 5, 2026

View reviewed changes

justinmc previously approved these changes Aug 5, 2026

View reviewed changes

justinmc reviewed Aug 5, 2026

View reviewed changes

Renzo-Olivares dismissed justinmc’s stale review via 3b7046b August 6, 2026 18:41

Renzo-Olivares requested a review from justinmc August 6, 2026 18:41

justinmc previously approved these changes Aug 6, 2026

View reviewed changes

Renzo-Olivares dismissed justinmc’s stale review via 8bf380c August 7, 2026 20:47

Renzo-Olivares requested a review from justinmc August 7, 2026 20:48

justinmc approved these changes Aug 7, 2026

View reviewed changes

navaronbracke approved these changes Aug 7, 2026

View reviewed changes

refactor to not use material

a18934c

Renzo Olivares added 8 commits August 10, 2026 09:49

updates

3b79d23

Migrate to UIScene lifecycle to fix Runner

d65196d

update button naming

9ed0eea

address gemini comments

84e6b74

make Button private

ffd3cca

remove flutter_view from cross imports

593f85c

add back flutter_view

775d2f7

fix analyzer

a866f59

Renzo-Olivares force-pushed the flutter_view_revamp branch from 8bf380c to a866f59 Compare August 10, 2026 16:51

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2026

auto-submit Bot added this pull request to the merge queue Aug 10, 2026

Merged via the queue into flutter:master with commit 55e4f9c Aug 10, 2026
22 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2026

GhagSagar23 mentioned this pull request Aug 19, 2026

Refactor splash example to not use material_ui #191380

Open

10 tasks

Conversation

Renzo-Olivares commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android:

iOS:

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard Bot commented Aug 1, 2026

Uh oh!

navaronbracke commented Aug 4, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

navaronbracke commented Aug 4, 2026

Uh oh!

Renzo-Olivares commented Aug 5, 2026

Uh oh!

Renzo-Olivares Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

navaronbracke Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Renzo-Olivares commented Jul 31, 2026 •

edited

Loading

navaronbracke Aug 5, 2026 •

edited

Loading