Repository navigation
Revert: Prepare device support symbols - #190551
Closed
flutteractionsbot wants to merge 1 commit into
Closed
flutteractionsbot wants to merge 1 commit into
flutteractionsbot wants to merge 1 commit into
Conversation
This reverts commit 86845f6.
10 tasks done
github-actions
Bot
added
platform-ios
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the IOSDeviceSupport class and its associated test file, device_support_test.dart. It cleans up IOSDevice by removing unused dependencies on ProcessUtils and Xcode, and inlines the debugger attachment check logic. Corresponding test files are updated to reflect these signature changes and remove obsolete test cases. There are no review comments, so I have no feedback to provide.
Contributor
|
Fix is already in queue: #190544 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts: Prepare device support symbols
Initiated by: @gaaclarke
Reason for reverting: This is causing dart analyze failures: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20analyze/31681/overview
Original PR Author: @vashworth
Reviewed By: @okorohelijah
The original PR description is provided below:
When debugging for iOS devices, Device Support symbols are required to be copied from the iOS device to the host. Previously the only way to trigger this was to open Xcode. We recently discovered there's now a command that automates this.
This PR adds a command that calls
xcodebuild -prepareDeviceSupportbefore installing/launching the app so that Device Support symbols are verified to be installed.Toward #189284.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.