Repository navigation
Rename and restructure the primitive_shape_test test to engine_integration_golden_test - #190581
Merged
auto-submit[bot] merged 4 commits intoAug 5, 2026
Merged
Conversation
…ation_golden_test.
b-luk
marked this pull request as ready for review
August 4, 2026 23:10
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames and refactors the primitive_shape_test integration test suite to engine_integration_golden_test. The changes include updating CI target configurations in .ci.yaml, renaming the test directory and associated files, updating the Dart package name and workspace references in pubspec.yaml, and refactoring the test code and helper functions. There are no review comments, and I have no feedback to provide.
Contributor
Author
|
PTAL. I missed updating the TESTOWNERS file. |
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #190301
Renames the specific primitive_shape_test to a more generic engine_integration_golden_test.
The original lib/main.dart of the test is renamed lib/primitive_shape_main.dart. We anticipate adding further tests with their own main.dart in lib/, and importing and using each one in integration_test/engine_integration_golden_test.dart.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.