Repository navigation
Migrate the embedder tests from the legacy Dart native function format to FFI - #190615
Merged
auto-submit[bot] merged 1 commit intoAug 5, 2026
Merged
Conversation
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates native callbacks in engine unit tests and platform test fixtures (macOS, Windows, and embedder) from the legacy CREATE_NATIVE_ENTRY and AddNativeCallback mechanism to Dart FFI using CREATE_FFI_LAMBDA and AddFfiNativeCallback. Dart test fixtures are updated to use @Native annotations. The review feedback recommends optimizing several captureless or effectively captureless lambdas by converting them directly to function pointers using the unary + operator, which avoids the memory leak and runtime overhead of CREATE_FFI_LAMBDA.
b-luk
approved these changes
Aug 5, 2026
jason-simmons
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #190154