Skip to content

[Reland] Enable Gradle cache for CI on single test target - #190635

Merged
jtmcdole merged 2 commits into
flutter:masterfrom
mboetger:reland-enable-cache
Aug 7, 2026
Merged

jtmcdole merged 2 commits into
flutter:masterfrom
mboetger:reland-enable-cache

Conversation

@mboetger

@mboetger mboetger commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

This is a reland of #190474. Now using ':' - which should not break the validate luci test.

In https://cs.opensource.google/flutter/infra/+/main:config/lib/ci_yaml/ci_yaml.star;l=93-95 the swarming cache names are created. This is what broke on the last go - the cache names did not fit the regex: ^[a-z0-9_]+$

Before:
flutter_main_gradle_dists_8_4_bin, 8_13_rc_1_bin, 8_14_bin, 9_3_1_bin, 9_3_1_all ❌ does not match
After:
flutter_main_gradle_dists_8_4_bin_8_13_rc_1_bin_8_14_bin_9_3_1_bin_9_3_1_all ✅ does match

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@mboetger mboetger added the CICD Run CI/CD label Aug 5, 2026
@mboetger
mboetger marked this pull request as ready for review August 6, 2026 16:09
@mboetger
mboetger requested a review from jtmcdole August 6, 2026 16:09

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .ci.yaml configuration file by adding the gradle_dists dependency with specified versions to the tool_tests_commands target. There are no review comments, and I have no feedback to provide.

@mboetger

mboetger commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Tested with led: https://ci.chromium.org/b/8674191260583919457

@jtmcdole jtmcdole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was there when he tested this with led.

video_1785183269211902_480

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2026
@jtmcdole
jtmcdole enabled auto-merge August 6, 2026 19:34
@mboetger mboetger added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD and removed autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Aug 6, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2026
@auto-submit

auto-submit Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/190635, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants