Repository navigation
[web] Filter non-fatal Chromium D-Bus error lines from Chrome stderr - #190669
Merged
auto-submit[bot] merged 9 commits intoAug 13, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures the DBUS_SESSION_BUS_ADDRESS environment variable to unix:path=/dev/null when launching Chromium on Linux if it is missing, empty, or set to /dev/null. Feedback on the changes suggests refactoring to avoid duplication: specifically, removing the redundant kChromeLinuxArgs constant in the tests in favor of kChromeArgs, and extracting the duplicated environment setup logic in chrome.dart into a shared private helper getter.
mdebbar
changed the title
mdebbar
force-pushed
the
fix-chrome-dbus-address
branch
from
August 6, 2026 19:19
31a2b73 to
5a4c9b5
Compare
mdebbar
changed the title
mdebbar
changed the title
github-actions
Bot
added
tool
mdebbar
added
the
autosubmit
kevmoo
reviewed
Aug 12, 2026
| /// We filter out these benign D-Bus lines to prevent stderr log noise in CI, | ||
| /// following the industry standard pattern used by open source projects to filter | ||
| /// E2E test logs (e.g. https://github.com/kitelev/exocortex/blob/4290cdade669034e5f71c892fb3e1908c5a2fe12/packages/obsidian-plugin/docker-entrypoint-e2e.sh#L48-L49). | ||
| bool _isDbusError(String line) { |
Contributor
There was a problem hiding this comment.
SO MUCH identical code. Any reasonable place to allow sharing?
Contributor
Author
There was a problem hiding this comment.
I filed this issue some time ago: #176051. I agree this duplication isn't great.
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/190669, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
mdebbar
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Chrome launcher environment setup in
flutter_tools,devicelab, andweb_ui(felt) on Linux.When running headless Chrome tests in a Linux container or VM without a desktop environment, Chromium attempts to connect to the D-Bus system daemon (for things like desktop notifications and system themes) and prints benign but annoying error logs to
stderrwhen it fails (e.g.ERROR:dbus/bus.cc,Failed to connect to the bus).This PR filters out these non-fatal D-Bus connection error messages emitted by Chromium. This follows the industry standard pattern used by other open source projects to filter out stderr noise in E2E tests (e.g., exocortex).