Repository navigation
Conversation
`GoldenTestManager` had an option to choose between an `impeller_` and a bare golden name prefix based on the `FLTEnableImpeller` key in the app's Info.plist, and the app had an `Info_Skia.plist` that set this to false. Both of those have been dead code since 2025-02-25 when we stopped reading `FLTEnableImpeller` in flutter#163808, which switched iOS to the slimpeller variant, and no build configuration ever pointed `INFOPLIST_FILE` at `Info_Skia.plist`. It it was only listed in the project navigator for manual use. The only remaining reader of that flag in the tree is the macOS embedder. This removes the branch, both `Info_Skia.plist` files, and the now-dead `FLTEnableImpeller` key from the Scenarios app. We keep the `impeller_` tag on the goldens even though it's redundant, since that involves touching a bunch of PNGs. If we ever need to do that, we can do it separately. No test changes, or all test changes depending how you look at it, but either way this is dead code removal. Issue: flutter#190041 Issue: flutter#112232
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the Skia-specific configuration files and the FLTEnableImpeller plist keys from the iOS scenario app, simplifying the golden image test manager to assume Impeller is always enabled. I have no feedback to provide.
hellohuanlin
approved these changes
Aug 10, 2026
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoldenTestManagerhad an option to choose between animpeller_and a bare golden name prefix based on theFLTEnableImpellerkey in the app's Info.plist, and the app had anInfo_Skia.plistthat set this to false.Both of those have been dead code since 2025-02-25 when we stopped reading
FLTEnableImpellerin #163808, which switched iOS to the slimpeller variant, and no build configuration ever pointedINFOPLIST_FILEatInfo_Skia.plist. It it was only listed in the project navigator for manual use. The only remaining reader of that flag in the tree is the macOS embedder.This removes the branch, both
Info_Skia.plistfiles, and the now-deadFLTEnableImpellerkey from the Scenarios app.We keep the
impeller_tag on the goldens even though it's redundant, since that involves touching a bunch of PNGs. If we ever need to do that, we can do it separately.No test changes, or all test changes depending how you look at it, but either way this is dead code removal.
Issue: #190041
Issue: #112232
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.