Repository navigation
[flutter_tools] Add integration coverage for test presets - #190858
Conversation
github-actions
Bot
added
the
tool
|
Closing this draft until the account holder has personally reviewed and understood the AI-assisted changes, as required by Flutter’s AI contribution guidelines. The fork branch is retained for that review. |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
447d883 to
f3eabf0
Compare
|
Maintainer label request: please add |
f3eabf0 to
9fee492
Compare
Boulea7
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support and integration tests for the test preset option in flutter test. It introduces a test configuration file (dart_test.yaml) defining presets, a test file (preset_test.dart) to verify preset application, and integration tests in test_test.dart to validate the short and long preset options, undefined preset handling, and combination of presets with other options. I have no feedback to provide.
bkonyi
left a comment
bkonyi
left a comment
There was a problem hiding this comment.
LGTM! This just needs another review before it can land.
Exercise short and long preset flags through the real flutter test command, including undefined presets and combination with name filters. This extends the unit coverage added in flutter#190878.
9fee492 to
cee75ff
Compare
chingjun
added
CICD
flutter-dashboard
Bot
removed
the
autosubmit
4 participants
#190878 added
--preset/-Psupport toflutter test. This PR adds real-command integration coverage for that behavior in both the standard and experimental faster test runners.The tests exercise the short and long flag forms, an undefined preset, composition with
--plain-name, and a two-file--experimental-faster-testinginvocation.Related to #189191.
Tests
../../bin/flutter test --no-pub test/commands.shard/hermetic/test_test.dart(56 tests)../../bin/flutter test --no-pub test/integration.shard/test_test.dart --concurrency=1(39 tests)../../bin/flutter test --no-pub --experimental-faster-testing -P passing flutter_test/preset_test.dart flutter_test/trivial_test.dart./bin/dart analyze --fatal-infos packages/flutter_tools/lib/src/commands/test.dart packages/flutter_tools/lib/src/test/runner.dart packages/flutter_tools/test/commands.shard/hermetic/test_test.dart packages/flutter_tools/test/integration.shard/test_test.dart dev/automated_tests/flutter_test/preset_test.dart./bin/dart format --output=none --set-exit-if-changed packages/flutter_tools/lib/src/commands/test.dart packages/flutter_tools/lib/src/test/runner.dart packages/flutter_tools/test/commands.shard/hermetic/test_test.dart packages/flutter_tools/test/integration.shard/test_test.dart dev/automated_tests/flutter_test/preset_test.dart./bin/flutter analyze --flutter-repogit diff --checkPre-launch Checklist
///). No public API is added by this test-only change.