Repository navigation
Make web test subshards dynamically determined by .ci.yaml - #191003
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the subshard naming convention in .ci.yaml and refactors _runWebUnitTests in run_web_tests.dart to dynamically parse subshard indices and totals from the environment. Feedback highlights a bug in the legacy fallback logic where legacyShardCount is hardcoded to 8, which would cause issues for web_skwasm_tests that historically used 2 shards.
Piinks
added
platform-web
Contributor
|
FYI @eyebrowsoffire |
harryterkelsen
previously approved these changes
Sep 23, 2026
harryterkelsen
left a comment
harryterkelsen
left a comment
Contributor
There was a problem hiding this comment.
LGTM with nit about comment
github-actions
Bot
added
team-web
harryterkelsen
approved these changes
Sep 24, 2026
harryterkelsen
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 25, 2026
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors web unit test subsharding (
web_canvaskit_testsandweb_skwasm_tests) so that the subshard count is dynamically dictated by what is specified in.ci.yamlusing the standard{index}_{total}format (e.g.1_8,1_2,2_2).dev/bots/suite_runners/run_web_tests.dart: Refactored_runWebUnitTeststo parse theSUBSHARDenvironment variable viaselectIndexOfTotalSubshard<String>(allTests)when formatted as{index}_{total}. Automatically executes the extraflutter_web_pluginsandflutter_driverweb extension tests on the last subshard (index == total). Retains fallback support for legacy single-number and_lastsubshard names..ci.yaml: Preserved targetname:fields unchanged (Linux web_canvaskit_tests_0..7_last,Linux web_skwasm_tests_0&1), while updatingsubshard:properties to"1_8".."8_8"and"1_2"/"2_2".Verification
dart analyze --fatal-infos dev/bots/suite_runners/run_web_tests.dartdart format dev/bots/suite_runners/run_web_tests.dartbin/cache/dart-sdk/bin/dart dev/bots/test/ci_yaml_validation_test.dart