Repository navigation
Migrate framework rules to analyzer plugin - #191035
Merged
auto-submit[bot] merged 14 commits intoAug 13, 2026
Merged
Conversation
github-actions
Bot
added
the
framework
bkonyi
marked this pull request as ready for review
August 13, 2026 14:38
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the custom no-runtime-type and null-fields validations from the legacy analyze.dart script into the flutter_analyzer_plugin as proper analyzer rules (NoRuntimeTypeInToString and NullInitializedDebugExpensiveFields). Feedback suggests adding public documentation to the new rule classes, ignoring runtimeType inside assertion statements to prevent false positives (along with adding a corresponding test case), and making the NullInitializedDebugExpensiveFields rule more robust by handling parenthesized or prefixed kDebugMode identifiers.
github-actions
Bot
removed
the
framework
srawlins
approved these changes
Aug 13, 2026
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Aug 14, 2026
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates legacy string-based checks (
verifyNoRuntimeTypeInToStringandverifyNullInitializedDebugExpensiveFields) fromdev/bots/analyze.darttodev/flutter_analyzer_pluginto provide real-time IDE diagnostics and AST-based validation.Changes
no_runtimetype_in_tostringandnull_initialized_debug_expensive_fields.dev/flutter_analyzer_plugin/test/.packages/flutter/lib/analysis_options.yaml.dev/bots/analyze.dart.