Repository navigation
Migrate internal import rules to analyzer plugin - #191036
Conversation
github-actions
Bot
added
tool
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates bad import verification checks for the flutter and flutter_tools packages from the legacy analyze.dart script to the flutter_analyzer_plugin as custom lint rules. Feedback highlights that this migration introduces a regression by omitting global validations like layer dependency, loop detection, and package structure verification. Additionally, the new lint rules need to be restricted to specific directories to prevent false positives in test and public export files, and the new public classes require proper documentation.
github-actions
Bot
removed
the
tool
…efer_relative_imports lint
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/191036, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter-dashboard
Bot
removed
the
autosubmit
2 participants
Migrates legacy string-based import checks (
verifyNoBadImportsInFlutterandverifyNoBadImportsInFlutterTools) fromdev/bots/analyze.darttodev/flutter_analyzer_pluginto provide real-time IDE diagnostics and AST-based import validation.Changes
no_bad_imports_in_flutterandno_bad_imports_in_flutter_tools.dev/flutter_analyzer_plugin/test/.packages/flutter/lib/analysis_options.yamlandpackages/flutter_tools/analysis_options.yaml.dev/bots/analyze.dart.