Repository navigation
[stable] Fix space formatting in cherry-pick label for flutter_cp.dart - #191123
Conversation
…r#189463) Fixes the label formatting in flutter_cp.dart so that gh api adds 'cp: <channel>' instead of creating a new label without a space.
|
@bkonyi please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds validation to ensure the channel argument is either 'stable' or 'beta' and updates the label generation logic in addLabel(). The reviewer suggests simplifying addLabel() by directly using the validated channel variable in the command arguments, which would eliminate the redundant switch expression.
bkonyi
changed the title
reidbaker
added
the
autosubmit
7a013b0
into
flutter:flutter-3.47-candidate.0
3 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
N/A (Fixes cherry-pick helper script bug from #189463)
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.
When running the cherry-pick agent helper script (
flutter_cp.dart) on a release branch, the script adds unspaced label arguments (cp:stableorcp:beta) instead ofcp: stableorcp: beta. This results in creating unintended, duplicate repository labels.Changelog Description:
Explain this cherry pick:
See best practices for examples.
[flutter/189463] When running the cherry-pick helper script, incorrect label argument formatting causes unintended repository label creation.
Workaround:
Is there a workaround for this issue?
Manually add the correct channel label (
cp: stableorcp: beta) with a space via GitHub UI/CLI, and remove the unspaced label.Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
dart .agents/skills/flutter-cherry-pick/scripts/flutter_cp.dart --pr <PR> --channel stable --action start.cp: stable(with space) is added to the PR and no duplicate unspaced label is created.