Repository navigation
Only exclude platform directories that actually exist in analysis_options.yaml - #191151
Merged
auto-submit[bot] merged 1 commit intoAug 19, 2026
Conversation
github-actions
Bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the analysis options migration and template generation in flutter_tools to conditionally exclude platform directories (such as android, ios, web, windows, macos, and linux) only if they exist in the project. Additionally, the migration is skipped entirely for pure Dart packages that do not have a flutter dependency. Unit and integration tests have been added to verify these changes. There are no review comments, and I have no feedback to provide.
chingjun
approved these changes
Aug 18, 2026
chingjun
added
CICD
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/191151, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…ions.yaml AnalysisOptionsMigration wrote a fixed seven-entry exclude list (android/**, ios/**, web/**, windows/**, macos/**, linux/**) regardless of which platforms a project actually has, so a Dart-only package using web/ as a source directory (e.g. `dart create -t web`) silently lost analysis coverage, and a Flutter app created with --platforms=android,ios still got exclusions for platforms it doesn't have. The migration now skips entirely for non-Flutter packages (no `flutter` dependency) and only excludes a platform directory if project.<platform>.existsSync() is true. The `flutter create` app template's analysis_options.yaml.tmpl is updated the same way, using the existing per-platform mustache context. Fixes flutter#191131
chingjun
force-pushed
the
fix-analysis-options-web-exclude-191131
branch
from
August 18, 2026 19:40
c47cafa to
d564667
Compare
chingjun
added
CICD
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Aug 19, 2026
AlexV525
added
cp: beta
Contributor
|
Failed to create CP due to merge conflicts. |
Closed
2 of 5 tasks
AlexV525
added
cp: beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnalysisOptionsMigrationwrote a fixed seven-entryexcludelist (android/**,ios/**,web/**,windows/**,macos/**,linux/**, plusbuild/**) intoanalysis_options.yamlon everyflutter pub get/flutter analyze/flutter run/flutter build, regardless of what the project actually contains.Two concrete problems from this:
dart create -t web) that usesweb/as a real source directory gets it silently excluded from analysis the first time anyfluttercommand touches the package (this happens in mixed Flutter/Dart monorepos and Dart workspaces).flutter create --platforms=android,iosstill gets exclusions forweb/,windows/,macos/, andlinux/, which it doesn't have, andProjectMigratorhas no opt-out — every command restores the full list.Fix:
AnalysisOptionsMigration.migrate()now skips entirely when the package has noflutterdependency (i.e. it isn't a Flutter project at all — the discriminator suggested in the issue).project.<platform>.existsSync()for each platform, so only directories the project actually has as platform scaffolds are excluded.build/**stays unconditional.templates/app/analysis_options.yaml.tmpl(used byflutter create) gets the same per-platform conditionals via the existing mustache context ({{#android}},{{#ios}}, etc.), so newly created projects don't get the fixed list either.Fixes #191131
Pre-launch Checklist
///).