Repository navigation
[Android] Fix respecting--enable-software-rendering in the embedding - #191321
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates FlutterEngineConnectionRegistry to check the manifest for software rendering configuration if it is not already enabled, and adds corresponding unit tests. The review feedback identifies that the new tests mock Intent but do not stub intent.hasExtra(...) to return true. This causes the intent-handling logic to be skipped during test execution, and the reviewer provides suggestions to stub this method.
github-actions
Bot
added
platform-android
|
|
||
| if (!useSoftwareRendering) { | ||
| // Check manifest for software rendering configuration. | ||
| useSoftwareRendering = flutterLoader.getSofwareRenderingEnabledViaManifest(); |
There was a problem hiding this comment.
Should this be moved to run before the if block above?
There was a problem hiding this comment.
No because the warning is only related to useSoftwareRendering defined via Intent, not manifest.
camsim99
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/191321, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
chingjun
added
the
autosubmit
camsim99
added
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
3 participants
Fixes regression caused by #190222 that accidentally stopped respecting the
enable-software-renderingIntent flag in the Android embedding.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.