Repository navigation
[cupertino] Remove unused parameters from constructors of generic classes - #191398
Conversation
…sses. We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839 This change is mirrored at flutter/packages#12457
|
This pull request contains changes to Material or Cupertino, which are currently frozen in this repository. Changes should be made in Please refer to #188444 for instructions. |
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes unused super.key and super.settings parameters from the constructors of several private Cupertino classes, including _ContextMenuRoute, _CupertinoBackGestureDetector, _SegmentedControlRenderWidget, _CupertinoDragGestureDetector, and _CupertinoDraggableScrollableSheet. There are no review comments, and I have no feedback to provide.
|
flutter/packages#12457 has landed. |
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Similar to #191399 (review), this code is frozen but I assume that linting tools will complain if we don't make this change. Given that it should have no effect on users at all, I think it's fine to land.
2 participants
We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes.
This is work towards dart-lang/sdk#47839
This change is mirrored at flutter/packages#12457
Pre-launch Checklist
///).