Add more 0x0 size tests part 13 by ahmedsameha1 · Pull Request #191466 · flutter/flutter

ahmedsameha1 · 2026-08-21T03:58:24Z

This is my attempt to handle #6537 for the following widgets:
Viewport
ColoredBox
StatefulBuilder
Builder
RawImage
RichText
Flow
Wrap

gemini-code-assist

Code Review

This pull request adds tests to ensure that various widgets, including Viewport, RawImage, Builder, StatefulBuilder, ColoredBox, Flow, RichText, and Wrap, do not crash when rendered with a zero-area physical size. Feedback suggests removing the redundant tests for Builder and StatefulBuilder, as they are compositional widgets that do not perform layout or painting. Additionally, it is recommended to simplify the tests for RawImage, ColoredBox, Viewport, and Flow by removing the unnecessary Directionality wrapper, as these widgets do not depend on text direction.

gemini-code-assist · 2026-08-21T04:00:32Z

+  testWidgets('RawImage does not crash at zero area', (WidgetTester tester) async {
+    tester.view.physicalSize = Size.zero;
+    addTearDown(tester.view.reset);
+    await tester.pumpWidget(
+      const Directionality(
+        textDirection: TextDirection.ltr,
+        child: Center(child: RawImage()),
+      ),
+    );
+    expect(tester.getSize(find.byType(RawImage)), Size.zero);
+  });


RawImage does not depend on text direction and does not require a Directionality widget. We can simplify this test by removing the unnecessary Directionality wrapper.

testWidgets('RawImage does not crash at zero area', (WidgetTester tester) async { tester.view.physicalSize = Size.zero; addTearDown(tester.view.reset); await tester.pumpWidget( const Center(child: RawImage()), ); expect(tester.getSize(find.byType(RawImage)), Size.zero); });

References

Suggest simplification and refactoring: Assess whether the code can be made simpler or refactored to enhance readability and maintainability. ^(link)

gemini-code-assist · 2026-08-21T04:00:32Z

+  testWidgets('ColoredBox does not crash at zero area', (WidgetTester tester) async {
+    tester.view.physicalSize = Size.zero;
+    addTearDown(tester.view.reset);
+    await tester.pumpWidget(
+      const Directionality(
+        textDirection: TextDirection.ltr,
+        child: Center(
+          child: ColoredBox(color: Color(0xFFAABBCC), child: Placeholder()),
+        ),
+      ),
+    );
+    expect(tester.getSize(find.byType(ColoredBox)), Size.zero);
+  });


ColoredBox does not depend on text direction and does not require a Directionality widget. We can simplify this test by removing the unnecessary Directionality wrapper.

testWidgets('ColoredBox does not crash at zero area', (WidgetTester tester) async { tester.view.physicalSize = Size.zero; addTearDown(tester.view.reset); await tester.pumpWidget( const Center( child: ColoredBox(color: Color(0xFFAABBCC), child: Placeholder()), ), ); expect(tester.getSize(find.byType(ColoredBox)), Size.zero); });

References

Suggest simplification and refactoring: Assess whether the code can be made simpler or refactored to enhance readability and maintainability. ^(link)

Not necessary, but feel free to adopt it if you feel like.

gemini-code-assist · 2026-08-21T04:00:32Z

+  testWidgets('Flow does not crash at zero area', (WidgetTester tester) async {
+    tester.view.physicalSize = Size.zero;
+    addTearDown(tester.view.reset);
+    await tester.pumpWidget(
+      Directionality(
+        textDirection: TextDirection.ltr,
+        child: Center(
+          child: Flow(delegate: OpacityFlowDelegate(0.2), children: const <Widget>[Placeholder()]),
+        ),
+      ),
+    );
+    expect(tester.getSize(find.byType(Flow)), Size.zero);
+  });


Flow does not depend on text direction and does not require a Directionality widget. We can simplify this test by removing the unnecessary Directionality wrapper.

testWidgets('Flow does not crash at zero area', (WidgetTester tester) async { tester.view.physicalSize = Size.zero; addTearDown(tester.view.reset); await tester.pumpWidget( Center( child: Flow(delegate: OpacityFlowDelegate(0.2), children: const <Widget>[Placeholder()]), ), ); expect(tester.getSize(find.byType(Flow)), Size.zero); });

References

Suggest simplification and refactoring: Assess whether the code can be made simpler or refactored to enhance readability and maintainability. ^(link)

Not necessary, but feel free to adopt it if you feel like.

dkwingsmt

LGTM. Thank you!

auto-submit · 2026-09-03T21:34:19Z

autosubmit label was removed for flutter/flutter/191466, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

auto-submit · 2026-09-03T21:34:20Z

autosubmit label was removed for flutter/flutter/191466, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

dkwingsmt · 2026-09-09T20:23:20Z

Can you fix the analyzer issues?


Analysis in progress (150s)...
Analyzing flutter...                                            

   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1921:7 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1921:7 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1921:7 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1921:7 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:16 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:16 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:16 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:16 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:34 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:34 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:34 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:34 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:60 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:60 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:60 • prefer_const_constructors
   info • Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation • packages/flutter/test/widgets/basic_test.dart:1922:60 • prefer_const_constructors

16 issues found. (ran in 174.9s)
╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ Command: bin/flutter analyze --flutter-repo
║ Command exited with exit code 1 but expected zero exit code.
║ Working directory: /b/s/w/ir/x/w/flutter
╚═══════════════════════════════════════════════════════════════════════════════

dkwingsmt · 2026-09-14T19:41:40Z

There's a leaking error:


05:23 +11894 ~31 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/rendering/viewport_test.dart: (tearDownAll) [E]
  Expected: leak free
    Actual: <Instance of 'Leaks'>
     Which: contains leaks:
            # The text is generated by leak_tracker.
            # For leak troubleshooting tips open:
            # https://github.com/flutter/flutter/blob/main/docs/contributing/testing/Leak-tracking.md
            notDisposed:
              total: 1
              objects:
                _FixedViewportOffset:
                  test: Viewport does not crash at zero area
                  identityHashCode: 500155369
            
            
  
  package:matcher                                              expect
  package:leak_tracker_testing/src/leak_testing.dart 69:24     LeakTesting.collectedLeaksReporter.<fn>
  package:leak_tracker_flutter_testing/src/testing.dart 74:37  maybeTearDownLeakTrackingForAll
  ===== asynchronous gap ===========================
  dart:async                                                   Zone.registerBinaryCallback
  package:flutter_test/src/test_compat.dart 302:3              _tearDownForTestFile

Can you take a look?

ahmedsameha1 added 8 commits August 21, 2026 06:54

Make sure that a Wrap doesn't crash in 0x0 environment

ebc40f0

Make sure that a Flow doesn't crash in 0x0 environment

ab9138a

Make sure that a RichText doesn't crash in 0x0 environment

5fb02d1

Make sure that a RawImage doesn't crash in 0x0 environment

b973f9e

Make sure that a Builder doesn't crash in 0x0 environment

0b600b8

Make sure that a StatefulBuilder doesn't crash in 0x0 environment

1b6777d

Make sure that a ColoredBox doesn't crash in 0x0 environment

c227470

Make sure that a Viewport doesn't crash in 0x0 environment

b1bff3f

github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 21, 2026

gemini-code-assist Bot reviewed Aug 21, 2026

View reviewed changes

justinmc requested review from dkwingsmt and victorsanni September 3, 2026 20:40

dkwingsmt previously approved these changes Sep 3, 2026

View reviewed changes

victorsanni previously approved these changes Sep 3, 2026

View reviewed changes

victorsanni added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Sep 3, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2026

ahmedsameha1 dismissed stale reviews from victorsanni and dkwingsmt via d29260a September 4, 2026 09:42

flutter-dashboard Bot removed the CICD Run CI/CD label Sep 4, 2026

dkwingsmt added the CICD Run CI/CD label Sep 8, 2026

flutter-dashboard Bot removed the CICD Run CI/CD label Sep 8, 2026

dkwingsmt added the CICD Run CI/CD label Sep 8, 2026

Remove unnecessary Directionality from some zero area tests

e0036b5

ahmedsameha1 force-pushed the add_more_0x0_size_tests_part_13 branch from 11fda5c to e0036b5 Compare September 10, 2026 15:49

Merge branch 'master' into add_more_0x0_size_tests_part_13

6c5b059

flutter-dashboard Bot removed the CICD Run CI/CD label Sep 11, 2026

dkwingsmt added the CICD Run CI/CD label Sep 11, 2026

Fix a leak in the zero area test of Viewport

c3338bb

ahmedsameha1 dismissed stale reviews from dkwingsmt and victorsanni via c3338bb September 16, 2026 14:33

flutter-dashboard Bot removed the CICD Run CI/CD label Sep 16, 2026

dkwingsmt approved these changes Sep 16, 2026

View reviewed changes

dkwingsmt added the CICD Run CI/CD label Sep 16, 2026

Merge branch 'master' into add_more_0x0_size_tests_part_13

c1b771e

flutter-dashboard Bot removed the CICD Run CI/CD label Sep 16, 2026

justinmc requested a review from victorsanni September 24, 2026 20:33

victorsanni approved these changes Sep 24, 2026

View reviewed changes

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2026

Merge branch 'master' into add_more_0x0_size_tests_part_13

9183e4c

victorsanni added the CICD Run CI/CD label Sep 24, 2026

auto-submit Bot added this pull request to the merge queue Sep 24, 2026

Merged via the queue into flutter:master with commit 66b298d Sep 24, 2026
21 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2026

Navigation Menu

Repository navigation

Add more 0x0 size tests part 13 - #191466

Add more 0x0 size tests part 13#191466
auto-submit[bot] merged 14 commits into
flutter:masterfrom
ahmedsameha1:add_more_0x0_size_tests_part_13

ahmedsameha1 commented Aug 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Uh oh!

dkwingsmt Sep 3, 2026

Uh oh!

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Uh oh!

dkwingsmt Sep 3, 2026

Uh oh!

dkwingsmt left a comment

Uh oh!

auto-submit Bot commented Sep 3, 2026

Uh oh!

auto-submit Bot commented Sep 3, 2026

Uh oh!

dkwingsmt commented Sep 9, 2026

Uh oh!

dkwingsmt commented Sep 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ahmedsameha1 commented Aug 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Sep 3, 2026

Uh oh!

auto-submit Bot commented Sep 3, 2026

Uh oh!

dkwingsmt commented Sep 9, 2026

Uh oh!

dkwingsmt commented Sep 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants