Repository navigation
[CP-beta]Always update swift package dependencies - #191513
Merged
Conversation
We originally added the `-skipPackageUpdates` flag when doing `xcodebuild` commands that didn't impact the build (like `xcodebuild -list`) so try to improve performance. However, I suspect this causes packages not to resolve properly during those commands. This PR removed the `-skipPackageUpdates` flag. Speculative fix for flutter#188265. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Contributor
Author
|
@vashworth please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
Bot
added
platform-ios
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the skipPackageUpdatesAndValidation parameter to skipPackageValidation across the iOS and macOS build tools and tests, and removes the -skipPackageUpdates flag from the xcodebuild arguments. Feedback suggests updating an outdated code comment in xcodeproj.dart to accurately reflect that the parameter now specifically controls package validation.
Comment on lines
+397
to
+399
| // skipPackageValidation should be false so that when subsequent xcodebuild | ||
| // commands run, packages should already be resolved, downloaded, updated, and validated. | ||
| skipPackageUpdatesAndValidation: false, | ||
| skipPackageValidation: false, |
Contributor
There was a problem hiding this comment.
Since -skipPackageUpdates has been removed, packages are now always resolved, downloaded, and updated regardless of the skipPackageValidation argument. The comment should be updated to reflect that skipPackageValidation: false specifically ensures packages are validated.
Suggested change
| // skipPackageValidation should be false so that when subsequent xcodebuild | |
| // commands run, packages should already be resolved, downloaded, updated, and validated. | |
| skipPackageUpdatesAndValidation: false, | |
| skipPackageValidation: false, | |
| // skipPackageValidation should be false so that when subsequent xcodebuild | |
| // commands run, packages should already be validated. | |
| skipPackageValidation: false, |
camsim99
approved these changes
Aug 24, 2026
camsim99
added
the
autosubmit
auto-submit
Bot
merged commit Aug 24, 2026
85f14e0
into
flutter:flutter-3.48-candidate.0
10 checks passed
flutteractionsbot
deleted the
cp-beta-31223582269154d859a640eabf2671b6aaea8ca9
branch
August 24, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#188265
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.
iOS or macOS builds may fail when Swift Package Manager is enabled.
Changelog Description:
Explain this cherry pick:
See best practices for examples.
< Replace with changelog description here >
[flutter/188265] When building for iOS or macOS with Swift Package Manager enabled, swift package dependencies may fail to resolve due to no version matching requirements.
Workaround:
Is there a workaround for this issue?
Disable SwiftPM:
flutter config --no-enable-swift-package-managerRisk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
The error is not reproducible so the fix is speculative.