Repository navigation
Show InputDecoration.errorText when the field is disabled in M2 - #191662
Closed
kaluli123123 wants to merge 1 commit into
Closed
kaluli123123 wants to merge 1 commit into
kaluli123123 wants to merge 1 commit into
Conversation
_InputDecoratorDefaultsM2.errorStyle resolved the error text color to Colors.transparent for the disabled state. The subtext row is still laid out for the error, so a disabled field with an errorText reserved space below the input but painted nothing, leaving an unexplained gap. The Material 3 defaults already paint the error text with the error color in every state. This change removes the disabled special case from the Material 2 defaults so both align, and the space that is reserved for the error is used by the visible error text. Fixes flutter#67409
|
This pull request contains changes to Material or Cupertino, which are currently frozen in this repository. Changes should be made in Please refer to #188444 for instructions. |
github-actions
Bot
added
a: text input
Contributor
Author
|
Material is frozen in flutter/flutter (see #188444), so this is ported to flutter/packages instead: flutter/packages#12589. Closing this in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_InputDecoratorDefaultsM2.errorStyle resolved the error text color to
Colors.transparent for the disabled state. The subtext row is still laid
out for the error, so a disabled field with an errorText reserved space
below the input but painted nothing, leaving an unexplained gap.
The Material 3 defaults already paint the error text with the error
color in every state. This change removes the disabled special case from
the Material 2 defaults so both align, and the space that is reserved
for the error is used by the visible error text.
Fixes #67409
Pre-launch Checklist
///).