Repository navigation
Deflake hybrid_android_views_integration_test - #191830
Merged
auto-submit[bot] merged 3 commits intoSep 2, 2026
Merged
auto-submit[bot] merged 3 commits into
auto-submit[bot] merged 3 commits into
Conversation
gmackall
marked this pull request as ready for review
September 1, 2026 20:34
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates FutureDataHandler to lazily initialize completers and handle null messages, refactors page transitions in main.dart to use PageRouteBuilder with zero transition durations, and adds a wait for transient callbacks in the integration test. Feedback suggests adding a timeout to the lazy completer future in handleMessage to prevent tests from hanging indefinitely on invalid messages.
gmackall
requested review from
a team and
camsim99
and removed request for
a team
September 2, 2026 17:35
camsim99
approved these changes
Sep 2, 2026
gmackall
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change resolves two sources of flakiness in
hybrid_android_views_integration_test:FutureDataHandlerto lazily create and await aCompleterwhen a driver message arrives beforeregisterHandleris called byonPlatformViewCreated, preventing premature "unsupported driver message" errors._pushPageto usePageRouteBuilderwith zero transition duration and addswaitUntilNoTransientCallbacks()before running motion event replay tests, eliminating in-flight coordinate transformation offsets on embedded platform views.should help with #190992