Skip to content

[CP-stable]Fix Actions.handler to forward the intent type to maybeFind - #192203

Merged
auto-submit[bot] merged 1 commit into
flutter:flutter-3.47-candidate.0from
flutteractionsbot:cp-stable-4adbf280095fd0a48f9ee690723582df958ef933
Sep 2, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:flutter-3.47-candidate.0from
flutteractionsbot:cp-stable-4adbf280095fd0a48f9ee690723582df958ef933

Conversation

@flutteractionsbot

@flutteractionsbot flutteractionsbot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#191045

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

All users of the Actions.handler API on all platforms are broken by this bug.

Changelog Description:

Explain this cherry pick:

  • In one line that is accessible to most Flutter developers.
  • That describes the state prior to the fix.
  • That includes which platforms are impacted.
    See best practices for examples.

[flutter/191045] When calling Actions.handler on all platforms, null was always returned.

Workaround:

Is there a workaround for this issue?

End users would need to reimplement Actions.handler and Action._isEnabled, or switch to master/main channel, or revert to 3.44

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

Compare use of Actions.handler on Flutter 3.47 (broken) vs 3.44.

final callback = Actions.handler(context, MyIntent(...));

When broken, callback is always null. When fixed it is the VoidCallback that has been set up to handle the given intent.

…191052)

`Actions.handler` was calling `Actions.maybeFind(context)` without an
explicit type argument or the intent, so downward inference resolved `T`
to `Intent` and the action lookup used the literal `Intent` type instead
of the intent's concrete runtime type. Since apps register actions keyed
by their concrete `Intent` subtype, the lookup always missed and
`handler` returned `null` for every intent. This regressed in flutter#180883
and first shipped in 3.47.0.

The fix forwards the type and intent explicitly:
`Actions.maybeFind<T>(context, intent: intent)`.

## Tests

Adds regression tests for `Actions.handler`: it now finds and invokes
the bound action for the intent's runtime type, and still returns null
when the action is disabled or when no matching action is found. The
first test fails without the fix.

Fixes flutter#191045.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Victor Sanni <[email protected]>
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Sep 2, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 2, 2026
@flutteractionsbot

Copy link
Copy Markdown
Contributor Author

@justinmc please fill out the PR description above, afterwards the release team will review this request.

@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 2, 2026
@justinmc

justinmc commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

FYI @amake this PR was recreated from your #192006.

@justinmc
justinmc requested a review from victorsanni September 2, 2026 22:52
@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2026

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . This is quite a high impact regression with a simple fix.

@auto-submit
auto-submit Bot merged commit 75a5dd9 into flutter:flutter-3.47-candidate.0 Sep 2, 2026
12 of 14 checks passed
@flutteractionsbot
flutteractionsbot deleted the cp-stable-4adbf280095fd0a48f9ee690723582df958ef933 branch September 2, 2026 22:55
@amake

amake commented Sep 3, 2026

Copy link
Copy Markdown

FYI @amake this PR was recreated from your #192006.

Thank you!

For my own edification: could I have kicked off this process correctly given my current status (non-contributor, non-member)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD cp: review Cherry-picks in the review queue framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants